On 10/21/2024 11:49 PM, Jeff Johnson wrote:
On 10/21/24 04:56, Md Sadre Alam wrote:
...
diff --git a/drivers/mtd/nand/qpic_common.c b/drivers/mtd/nand/qpic_common.c
new file mode 100644
index 000000000000..570ab59ca12b
--- /dev/null
+++ b/drivers/mtd/nand/qpic_common.c
@@ -0,0 +1,757 @@
+// SPDX-License-Identifier: GPL-2.0-only
+/*
+ * Copyright (c) 2016, The Linux Foundation. All rights reserved.
I'm surprised you aren't adding a 2024 Qualcomm Innovation Center copyright
qpic_common.c file is derived from drivers/mtd/nand/raw/qcom_nandc.c file
so I am retaining the Copyright from the drivers/mtd/nand/raw/qcom_nandc.c file
...
+MODULE_LICENSE("GPL");
Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the
description is missing"), a module without a MODULE_DESCRIPTION() will
result in a warning when built with make W=1. Recently, multiple
developers have been eradicating these warnings treewide, and very few
(if any) are left, so please don't introduce a new one :)
Please add the missing MODULE_DESCRIPTION()
Sorry I missed it. Will add in next revision.
