> > diff --git a/drivers/mfd/max77705.c b/drivers/mfd/max77705.c > > new file mode 100644 > > index 000000000000..553f20a6cdd5 > > --- /dev/null > > +++ b/drivers/mfd/max77705.c > > @@ -0,0 +1,248 @@ > > +// SPDX-License-Identifier: GPL-2.0+ > > +// > > +// max77705.c - mfd core driver for the MAX77705 > (...) > > +// Copyright (C) 2024 Dzmitry Sankouski <dsankouski@xxxxxxxxx> > > Only the SPDX in C++ comments please. > This conflicts with https://patchwork.kernel.org/comment/25898728/ > > + (...) > > +++ b/include/linux/mfd/max77705-private.h > > @@ -0,0 +1,180 @@ > > +/* SPDX-License-Identifier: GPL-2.0 */ > > +// > > +// Maxim MAX77705 definitions. > > +// > > +// Copyright (C) 2015 Samsung Electronics, Inc. > > +// Copyright (C) 2024 Dzmitry Sankouski <dsankouski@xxxxxxxxx> > > No C++ please. This conflicts with https://patchwork.kernel.org/comment/25898728/ > > > + > > +#ifndef __LINUX_MFD_MAX77705_PRIV_H > > +#define __LINUX_MFD_MAX77705_PRIV_H > > + > > +#include <linux/pm.h> > > + > > +#define MAX77705_SRC_IRQ_CHG BIT(0) > > +#define MAX77705_SRC_IRQ_TOP BIT(1) > > +#define MAX77705_SRC_IRQ_FG BIT(2) > > +#define MAX77705_SRC_IRQ_USBC BIT(3) > > +#define MAX77705_SRC_IRQ_ALL (MAX77705_SRC_IRQ_CHG | MAX77705_SRC_IRQ_TOP | \ > > + MAX77705_SRC_IRQ_FG | MAX77705_SRC_IRQ_USBC) > > + > > +// MAX77705_PMIC_REG_PMICREV register > > No C++ please. This conflicts with https://patchwork.kernel.org/comment/25898728/ -- Best regards, Dzmitry
