Re: [RESEND PATCH v3] mtd: hisilicon: add device tree node for NAND controller

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On 2015/3/28 1:35, Brian Norris wrote:
> This would go through your arm-soc submaintainer; i.e., Wei Xu
> 
> But FWIW...

Yes, I will ping him to check the patch.

> 
> On Wed, Mar 25, 2015 at 03:04:51PM +0800, Zhou Wang wrote:
>> This patch adds dts support for NAND flash controller of Hisilicon Soc Hip04.
>> Now it is based on v4.0-rc5
>>
>> Changes in v3:
>> - Change E-mail address in signed-off-by to "wangzhou1@xxxxxxxxxxxxx"
>> Changes in v2:
>> - Base on v3.19-rc1
>> - Use nand-ecc-strength, nand-ecc-step-size to replace hisi,nand-ecc-bits
>> Changes in v1:
>> - Move partition and other board related information into board dts file:
>>   hip04-d01.dts
>>
>> Signed-off-by: Zhou Wang <wangzhou1@xxxxxxxxxxxxx>
>> ---
>>  arch/arm/boot/dts/hip04-d01.dts | 27 +++++++++++++++++++++++++++
>>  arch/arm/boot/dts/hip04.dtsi    |  7 +++++++
>>  2 files changed, 34 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/hip04-d01.dts b/arch/arm/boot/dts/hip04-d01.dts
>> index 40a9e33..ba04dd5 100644
>> --- a/arch/arm/boot/dts/hip04-d01.dts
>> +++ b/arch/arm/boot/dts/hip04-d01.dts
>> @@ -28,5 +28,32 @@
>>  		uart0: uart@4007000 {
>>  			status = "ok";
>>  		};
>> +
>> +		nand: nand@4020000 {
>> +			nand-bus-width = <8>;
>> +			nand-ecc-mode = "hw";
>> +			nand-ecc-strength = <16>;
>> +			nand-ecc-step-size = <1024>;
>> +
>> +			partition@0 {
>> +				label = "nand_text";
>> +				reg = <0x00000000 0x00400000>;
>> +			};
>> +
>> +			partition@00400000 {
>> +				label = "nand_monitor";
>> +				reg = <0x00400000 0x00400000>;
>> +			};
>> +
>> +			partition@00800000 {
>> +				label = "nand_kernel";
>> +				reg = <0x00800000 0x00800000>;
>> +			};
>> +
>> +			partition@01000000 {
>> +				label = "nand_fs";
>> +				reg = <0x01000000 0x1f000000>;
>> +			};
>> +		};
>>  	};
>>  };
>> diff --git a/arch/arm/boot/dts/hip04.dtsi b/arch/arm/boot/dts/hip04.dtsi
>> index 2388145..ac32fce 100644
>> --- a/arch/arm/boot/dts/hip04.dtsi
>> +++ b/arch/arm/boot/dts/hip04.dtsi
>> @@ -269,6 +269,13 @@
>>  			interrupts = <0 372 4>;
>>  		};
>>  
>> +		nand: nand@4020000 {
>> +			compatible = "hisilicon,504-nfc";
>> +			reg = <0x4020000 0x10000>, <0x5000000 0x1000>;
>> +			interrupts = <0 379 4>;
>> +			#address-cells = <1>;
>> +			#size-cells = <1>;
>> +		};
> 
> Seems reasonable and matches the binding we already accepted, so:
> 
> Reviewed-by: Brian Norris <computersforpeace@xxxxxxxxx>
> 

Thanks,
Zhou

>>  	};
>>  
>>  	etb@0,e3c42000 {
>> -- 
>> 1.9.1
>>
> 
> .
> 


--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]
  Powered by Linux