Quoting Rob Herring (2024-10-17 13:38:10) > On Wed, Oct 16, 2024 at 02:20:15PM -0700, Stephen Boyd wrote: > > Some configurations want to enable CONFIG_KUNIT without enabling > > CONFIG_OF_OVERLAY. The kunit overlay code already skips if > > CONFIG_OF_OVERLAY isn't enabled, so this select here isn't really doing > > anything besides making it easier to run the tests without them > > skipping. Remove the select and move the config setting to the > > drivers/of/.kunitconfig file so that the overlay tests can be run with > > or without CONFIG_OF_OVERLAY set to test either behavior. > > > > Fixes: 5c9dd72d8385 ("of: Add a KUnit test for overlays and test managed APIs") > > Doesn't really seem like a fix. Ok. Feel free to drop the tag. > Does this need to go into 6.12? It's only important for 6.12 if kernel configurators want to build the kernel with OF_OVERLAY_KUNIT_TEST enabled and not be forced to enable CONFIG_OF_OVERLAY. I don't mind if it waits a while.