On 10/16/24 2:51 AM, Johan Hovold wrote:
On Mon, Oct 14, 2024 at 08:47:29PM -0400, Jonathan Marek wrote:
See commit e67b45582c5e for explanation.
It's good that you reference commit e67b45582c5e ("arm64: dts: qcom:
sc8280xp-crd: enable rtc") but your commit message still needs to be
self-contained and provide the explanation here in some form (e.g.
quoted or paraphrased).
Also spell out the commit summary in parenthesis when referring to
commits as I did above.
Note: the 0xbc offset is arbitrary, it just needs to not be already in use.
How did you verify that nothing is using this offset on this platform? I
assume we need someone with access to the docs to make sure it's not in
use as we did for sc8280xp.
AFAIK qcom allocate things from the start of the SDAM, so allocating
from the end of the SDAM should be safe. And AFAIK this is supposed to
be a general purpose HLOS (linux/windows) SDAM block, so should be
mostly free to use.
(its possible windows uses this offset for something, I don't know about
that)
