On 16/10/2024 04:45, Troy Mitchell wrote: >>> + >>> + clock-frequency: >>> + description: >>> + Desired I2C bus clock frequency in Hz. As only fast and high-speed >>> + modes are supported by hardware, possible values are 100000 and 400000. >>> + enum: [100000, 400000] >>> + default: 100000 >>> + >>> + fifo-disable: >> >> Why is this a property of a board? Here, this ^^^^^^ >> >> Also, missing vendor prefix. >> >> >>> + type: boolean >>> + description: >>> + Whether to disable FIFO. If FIFO is turned on, it will be interrupted >>> + only when the FIFO depth is reached, which can reduce the frequency >>> + of interruption. >>> + default: false >> >> Drop > > It's a hardware FIFO instead of software. > Is it unnecessary in this file? > If is, why dma can be written in dt-binding. Because of what I asked earlier. Which 'dma' property are you asking about? 'use-dma'? There was rationale provided in favor. I would be more than happy to see similar rationale here. Best regards, Krzysztof