On 2024/10/15 16:02, Krzysztof Kozlowski wrote: > On 15/10/2024 09:51, Troy Mitchell wrote: >> The i2c of K1 supports fast-speed-mode and high-speed-mode, > > s/i2c/I2C/ > >> and supports FIFO transmission. >> >> Signed-off-by: Troy Mitchell <TroyMitchell988@xxxxxxxxx> >> --- >> .../bindings/i2c/spacemit,k1-i2c.yaml | 59 +++++++++++++++++++ >> 1 file changed, 59 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml >> >> diff --git a/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml b/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml >> new file mode 100644 >> index 000000000000..c1460ec2b323 >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/i2c/spacemit,k1-i2c.yaml >> @@ -0,0 +1,59 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/i2c/spacemit,k1-i2c.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: I2C controller embedded in SpacemiT's K1 SoC >> + >> +maintainers: >> + - Troy Mitchell <troymitchell988@xxxxxxxxx> >> + >> +properties: >> + compatible: >> + const: spacemit,k1-i2c > > There is no such vendor prefix. > >> + >> + reg: >> + maxItems: 1 >> + >> + interrupts: >> + maxItems: 1 >> + >> + clocks: >> + maxItems: 1 >> + >> + clock-frequency: >> + description: >> + Desired I2C bus clock frequency in Hz. As only fast and high-speed >> + modes are supported by hardware, possible values are 100000 and 400000. >> + enum: [100000, 400000] >> + default: 100000 >> + >> + fifo-disable: > > Why is this a property of a board? > > Also, missing vendor prefix. > > >> + type: boolean >> + description: >> + Whether to disable FIFO. If FIFO is turned on, it will be interrupted >> + only when the FIFO depth is reached, which can reduce the frequency >> + of interruption. >> + default: false > > Drop It's a hardware FIFO instead of software. Is it unnecessary in this file? If is, why dma can be written in dt-binding. > >> + >> +unevaluatedProperties: false > > This goes after required: block. > > >> + >> +required: >> + - compatible >> + - reg >> + - interrupts >> + - clocks >> + >> +examples: >> + - | >> + i2c0: i2c@d4010800 { > > Drop unused alias > >> + compatible = "spacemit,k1-i2c"; > > Best regards, > Krzysztof > Best regards, Troy
