On 10/15/24 09:32, Rob Herring wrote:
On Fri, Oct 11, 2024 at 07:56:02PM -0700, Florian Fainelli wrote:
Document the 'open-drain' property that allows configuring the PWM
controller outputs in open drain versus totem pole.
Signed-off-by: Florian Fainelli <florian.fainelli@xxxxxxxxxxxx>
---
Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml b/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml
index 119de3d7f9dd..12851c43a612 100644
--- a/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml
+++ b/Documentation/devicetree/bindings/pwm/brcm,bcm7038-pwm.yaml
@@ -25,6 +25,12 @@ properties:
clocks:
maxItems: 1
+ open-drain:
+ type: boolean
+ description:
+ Configure the outputs with open-drain structure, if omitted totem pole
+ structure is used.
+
There's one other PWM with 'open-drain' so move the definition to
pwm.yaml.
Ah indeed, there is one now, great.
Alternatively, 'drive-open-drain' is a much more commonly used
variation.
That name works just as well.
Another thing to consider is for any PWM controller with more than
1 output, you might want this to be per output and therefore should be
a flag in the cells.
Yes, that is a good point, this controller has two channels, so it seems
like increasing the #pwm-cells might be the way to go.
Thanks!
--
Florian
