On Mon, Oct 14, 2024 at 07:38:11AM +0000, Haylen Chu wrote: > Add devicetree binding documentation for thermal sensors integrated in > Sophgo CV1800 SoCs. > > Signed-off-by: Haylen Chu <heylenay@xxxxxxx> > --- > .../thermal/sophgo,cv1800-thermal.yaml | 57 +++++++++++++++++++ > 1 file changed, 57 insertions(+) > create mode 100644 Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > > diff --git a/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > new file mode 100644 > index 000000000000..14abeb7a272a > --- /dev/null > +++ b/Documentation/devicetree/bindings/thermal/sophgo,cv1800-thermal.yaml > @@ -0,0 +1,57 @@ > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/thermal/sophgo,cv1800-thermal.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Sophgo CV1800 on-SoC Thermal Sensor > + > +maintainers: > + - Haylen Chu <heylenay@xxxxxxx> > + > +description: Sophgo CV1800 on-SoC thermal sensor > + > +$ref: thermal-sensor.yaml# > + > +properties: > + compatible: > + enum: > + - sophgo,cv1800-thermal > + > + reg: > + maxItems: 1 > + > + clocks: > + maxItems: 1 > + > + interrupts: > + maxItems: 1 > + > + sample-rate-hz: > + minimum: 1 > + maximum: 1908 > + default: 1 1. Why this is a property of a board? 2. I do not see this property defined in any common schema and I am not sure if it even should. Sample rate appears from time to time, but not in context of thermal sensors, so this should have vendor prefix. Best regards, Krzysztof
