On Sun, Oct 13, 2024 at 11:32:36PM +0200, Cenk Uluisik wrote: > Implements a slightly modified rk3588s-orangepi-5b.dts from the vendor. > Unfortunately the &wireless_bluetooth and &wireless_wlan overlays don't seem > to compile, so I removed them for now: > > Error: arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts:20.1-20 Label or path wireless_bluetooth not found > Error: arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts:24.1-15 Label or path wireless_wlan not found > > Bigger parts of the rk3588s-orangepi-5.dts file were moved into a new > rk3588s-orangepi-5.dtsi file, so that both device trees from the orangepi-5 and 5b include from it and avoid including from the .dts. > > How does this board differ from the original Orange Pi 5? > - builtin eMMC storage > - no SPI NOR flash (u-boot, preboot etc. initiates from within the eMMC > storage) > - ap6275p Wifi module (like the Orange Pi 5 Plus) > - builtin BlueTooth module > > Beside that everything is exactly the same as far as I know. > > Signed-off-by: Cenk Uluisik <cenk.uluisik@xxxxxxxxxxxxxx> > --- > arch/arm64/boot/dts/rockchip/Makefile | 1 + > .../boot/dts/rockchip/rk3588s-orangepi-5.dts | 776 +----------------- > ...orangepi-5.dts => rk3588s-orangepi-5.dtsi} | 5 +- > .../boot/dts/rockchip/rk3588s-orangepi-5b.dts | 18 + > 4 files changed, 30 insertions(+), 770 deletions(-) > rewrite arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts (99%) > copy arch/arm64/boot/dts/rockchip/{rk3588s-orangepi-5.dts => rk3588s-orangepi-5.dtsi} (99%) > create mode 100644 arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts > \ No newline at end of file Hm? > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi > similarity index 99% > copy from arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts > copy to arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi > index feea6b20a6bf..739c4d9f58e0 100644 > --- a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dts > +++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5.dtsi > @@ -10,9 +10,6 @@ > #include "rk3588s.dtsi" > > / { > - model = "Xunlong Orange Pi 5"; > - compatible = "xunlong,orangepi-5", "rockchip,rk3588s"; > - > aliases { > ethernet0 = &gmac1; > mmc0 = &sdmmc; > @@ -763,4 +760,4 @@ &usb_host1_ohci { > > &usb_host2_xhci { > status = "okay"; > -}; > +}; > \ No newline at end of file And here > diff --git a/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts > new file mode 100644 > index 000000000000..049227af0252 > --- /dev/null > +++ b/arch/arm64/boot/dts/rockchip/rk3588s-orangepi-5b.dts > @@ -0,0 +1,18 @@ > +// SPDX-License-Identifier: (GPL-2.0+ OR MIT) > + > +/dts-v1/; > + > +#include "rk3588s-orangepi-5.dtsi" > + > +/ { > + model = "Xunlong Orange Pi 5B"; > + compatible = "rockchip,rk3588s-orangepi-5b", "rockchip,rk3588"; Bindings are before users. > +}; > + > +&sdhci { > + status = "okay"; > +}; > + > +&sfc { > + status = "disabled"; > +}; > \ No newline at end of file Patch errors here and in other places. > -- > 2.46.0 >