On Sun, Oct 13, 2024 at 11:32:37PM +0200, Cenk Uluisik wrote: > This commit adds the Xunlong Orange Pi 5b entry to the device tree > bindings inside the Documentation folder. I know you said I > should extend the Orange Pi 5 one with an enum, but I made a whole new > entry, because looking at all the other entries, they also create new > entries in a case "like this". I hope this is okay, or maybe I misunderstand something. > Thank you in advance. That's not suitable for commit msg. Explain the hardware. And no, use an enum. > > Signed-off-by: Cenk Uluisik <cenk.uluisik@xxxxxxxxxxxxxx> > --- > Documentation/devicetree/bindings/arm/rockchip.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/Documentation/devicetree/bindings/arm/rockchip.yaml b/Documentation/devicetree/bindings/arm/rockchip.yaml > index 687823e58c22..130f6ccc1658 100644 > --- a/Documentation/devicetree/bindings/arm/rockchip.yaml > +++ b/Documentation/devicetree/bindings/arm/rockchip.yaml > @@ -1053,6 +1053,11 @@ properties: > items: > - const: xunlong,orangepi-5 > - const: rockchip,rk3588s > + Please run scripts/checkpatch.pl and fix reported warnings. Then please run 'scripts/checkpatch.pl --strict' and (probably) fix more warnings. Some warnings can be ignored, especially from --strict run, but the code here looks like it needs a fix. Feel free to get in touch if the warning is not clear. Best regards, Krzysztof
