On Fri, Oct 11, 2024 at 12:11 AM Florian Fainelli <florian.fainelli@xxxxxxxxxxxx> wrote: > On 10/10/24 15:07, Linus Walleij wrote: > > This adds the MDIO block found in the BCM6846. The vendor tree > > calls it "mdio5" so we assume the right compatible for this > > particular version is "brcm,genet-mdio-v5". > > That the same IP block be present on systems using GENET and BCMBCA > routers, absolutely, but it is not really the same. The one present on > BCM6846 has an extra pair of registers adjacent to it: > > LVL_IRQ_CLEAR > LVL_IRQ_MASK > > There are other differences like bit 13 defining a "free running" MDIO > clock, that has never been present in any of the GENET or ASP variants > of mdio-bcm-unimac. > > Therefore an updated compatible string would be in order IMHO, thanks! OK I fix! Is it the same block on all the BCMBCA variants so I should call it "brcm,bcmbca-mdio" or is it bcm6846-specific so I should call it "brcm,bcm6846-mdio"? Yours, Linus Walleij
