Hi, Shu-hsiang:
On Wed, 2024-10-09 at 19:15 +0800, Shu-hsiang Yang wrote:
> Introduces the ISP pipeline driver for the MediaTek ISP raw and yuv
> modules. Key functionalities include data processing, V4L2 integration,
> resource management, debug support, and various control operations.
> Additionally, IRQ handling, platform device management, and MediaTek
> ISP DMA format support are also included.
>
> Signed-off-by: Shu-hsiang Yang <Shu-hsiang.Yang@xxxxxxxxxxxx>
> ---
[snip]
> +
> +static irqreturn_t mtk_thread_irq_raw(int irq, void *data)
> +{
> + struct mtk_raw_device *raw_dev = (struct mtk_raw_device *)data;
> + struct mtk_camsys_irq_info irq_info;
> +
> + if (unlikely(atomic_cmpxchg(&raw_dev->is_fifo_overflow, 1, 0)))
> + dev_info(raw_dev->dev, "msg fifo overflow\n");
> +
> + while (kfifo_len(&raw_dev->msg_fifo) >= sizeof(irq_info)) {
> + int len = kfifo_out(&raw_dev->msg_fifo, &irq_info, sizeof(irq_info));
> +
> + WARN_ON(len != sizeof(irq_info));
> +
> + dev_dbg(raw_dev->dev, "ts=%llu irq_type %d, req:%d/%d\n",
> + irq_info.ts_ns, irq_info.irq_type,
> + irq_info.frame_idx_inner, irq_info.frame_idx);
> +
> + /* error case */
> + if (unlikely(irq_info.irq_type == (1 << CAMSYS_IRQ_ERROR))) {
> + raw_handle_error(raw_dev, &irq_info);
> + continue;
> + }
> +
> + /* normal case */
> + /* inform interrupt information to camsys controller */
> + mtk_camsys_isr_event(raw_dev->cam, CAMSYS_ENGINE_RAW,
> + raw_dev->id, &irq_info);
mtk_camsys_isr_event() is not defined in this patch but defined in [8/10] patch.
This is weird to use a function defined in future.
Define this function in this patch or previous patch.
Regards,
CK
> + }
> +
> + return IRQ_HANDLED;
> +}
> +
