On Tue, 8 Oct 2024 09:52:50 +0200 Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: > On Mon, Oct 07, 2024 at 05:45:45PM +0200, Julien Stephan wrote: > > ad7380-4 is the only device from ad738x family that doesn't have an > > internal reference. Moreover its external reference is called REFIN in > > the datasheet while all other use REFIO as an optional external > > reference. If refio-supply is omitted the internal reference is > > used. > > > > Fix the binding by adding refin-supply and makes it required for > > ad7380-4 only. > > Maybe let's just use refio as refin? Reference-IO fits here well. > Otherwise you have two supplies for the same. Whilst it is ugly, the effort this series is going to in order to paper over a naming mismatch makes me agree with Krzysztof. I think adding a comment to the dt-binding would be sensible though as people might fall into this hole. Other than the missing ret =, rest of series looks fine to me Jonathan > > Best regards, > Krzysztof >
