On Thu, Oct 10, 2024 at 04:23:05PM +0800, Inochi Amaoto wrote: > On Thu, Oct 10, 2024 at 08:12:41AM +0200, Krzysztof Kozlowski wrote: > > On Thu, Oct 10, 2024 at 07:39:05AM +0800, Inochi Amaoto wrote: > > > Add compatibles string for the Sophgo SG2044 uarts. > > > > This we see from the diff, say something about hardware. > > The reason for this compatiable (and the hardware) is mainly in the > next patch. Will it be better to submit a new verion with improved > description? If so, I wonder whether I can reserve your ack. > > > I would just add it to starfive enum, but this is fine as well. Even after reading the second patch I don't understand why you shouldn't re-use the starfive compatible or make a new one that covers this quirk? At least I would see that as second patch is basically not needed. -- With Best Regards, Andy Shevchenko
