On Thu, Oct 10, 2024 at 08:12:41AM +0200, Krzysztof Kozlowski wrote: > On Thu, Oct 10, 2024 at 07:39:05AM +0800, Inochi Amaoto wrote: > > Add compatibles string for the Sophgo SG2044 uarts. > > This we see from the diff, say something about hardware. > The reason for this compatiable (and the hardware) is mainly in the next patch. Will it be better to submit a new verion with improved description? If so, I wonder whether I can reserve your ack. > > > > Signed-off-by: Inochi Amaoto <inochiama@xxxxxxxxx> > > --- > > .../devicetree/bindings/serial/snps-dw-apb-uart.yaml | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > > index 4cdb0dcaccf3..6963f89a1848 100644 > > --- a/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > > +++ b/Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml > > @@ -58,6 +58,10 @@ properties: > > - brcm,bcm11351-dw-apb-uart > > - brcm,bcm21664-dw-apb-uart > > - const: snps,dw-apb-uart > > + - items: > > + - enum: > > + - sophgo,sg2044-uart > > I would just add it to starfive enum, but this is fine as well. > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx> > > Best regards, > Krzysztof > Thanks. Regard, Inochi
