On Fri, Oct 04, 2024 at 02:08:49PM +0100, Srinivas Kandagatla wrote: > From: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> > > Trackpad HID device on T14s could be found on two possible slave addresses > (hid@15 and hid@2c) on i2c0 instance. > With the current state of DT boot, there is no way to patch the device > tree at runtime during boot. This, however results in non-functional > trackpad on Product Models 21N2ZC5PUS which have trackpad on hid@2c > slave address. > > This patch adds hid@2c device along with hid@15 to get it working on > both the variants. This should work as i2c-hid driver will stop > probing the device if there is nothing on the slave address, we can > actually keep both devices enabled in DT, and i2c-hid driver will > only probe the existing one. > > The only problem is that we cannot setup pinctrl in both device nodes, > as two devices with the same pinctrl will cause pin conflict that makes > the second device fail to probe. Let's move the pinctrl state up to > parent node along with the parent pinctrl to solve this problem. > > Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx> > --- > > Changes since v2: > - updated commit log > - added missing parent pinctrl Thanks for the update. Looks good to me now: Reviewed-by: Johan Hovold <johan+linaro@xxxxxxxxxx>
