Re: [PATCH v5 2/4] media: dt-bindings: Add OmniVision OV08X40

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 05/10/2024 11:31, Bryan O'Donoghue wrote:
+
+    properties:
+      endpoint:
+        $ref: /schemas/media/video-interfaces.yaml#
+        unevaluatedProperties: false
+
+        properties:
+          data-lanes:
+            oneOf:
+              - items:
+                  - const: 1
+                  - const: 2
+              - items:
+                  - const: 1
+                  - const: 2
+                  - const: 3
+                  - const: 4
+
+        required:
+          - data-lanes
+          - link-frequencies

I had some offline discussion with Laurent about this since, the logical conclusion of this would be anything from schemas/media/video-interfaces.yaml# would be valid.

And I'll admit I looked @ upstream examples and copied/pasted which also implies that the upstream examples aren't correct.

So, I'll v6 this with

   properties:
     endpoint:
       $ref: /schemas/media/video-interfaces.yaml#
       _additionalProperties_: false

       properties:
         link-frequencies: true
         data-lanes:
           oneOf:
             - items:
                 - const: 1
                 - const: 2
             - items:
                 - const: 1
                 - const: 2
                 - const: 3
                 - const: 4

       required:
         - data-lanes
         - link-frequencies

and then change the relevant upstream examples of unevaluatedProperties: false to additionalProperties: false.

---
bod




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux