Re: [PATCH] arm64: dts: ti: k3-am62-main: Update otap/itap values

[Bhavya Kapoor <b-kapoor@xxxxxx>]

Looks good to me !

On 25/09/24 01:23, Judith Mendez wrote:
> Update itap/itap values according to device datasheet [0].
>
> Now that we have fixed timing issues for am62x [1], lets
> change the otap/itap values back according to the device
> datasheet.
>
> [0] https://www.ti.com/lit/ds/symlink/am625.pdf
> [1] https://lore.kernel.org/linux-mmc/20240913185403.1339115-1-jm@xxxxxx/
>
> Signed-off-by: Judith Mendez <jm@xxxxxx>
Reviewed-by: Bhavya Kapoor<b-kapoor@xxxxxx>
> ---
>   arch/arm64/boot/dts/ti/k3-am62-main.dtsi | 47 ++++++++++++------------
>   1 file changed, 23 insertions(+), 24 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> index 5b92aef5b284..7194603fd3bc 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> +++ b/arch/arm64/boot/dts/ti/k3-am62-main.dtsi
> @@ -561,10 +561,9 @@ sdhci0: mmc@fa10000 {
>   		ti,clkbuf-sel = <0x7>;
>   		ti,otap-del-sel-legacy = <0x0>;
>   		ti,otap-del-sel-mmc-hs = <0x0>;
> -		ti,otap-del-sel-ddr52 = <0x5>;
> -		ti,otap-del-sel-hs200 = <0x5>;
> -		ti,itap-del-sel-legacy = <0xa>;
> -		ti,itap-del-sel-mmc-hs = <0x1>;
> +		ti,otap-del-sel-hs200 = <0x6>;
> +		ti,itap-del-sel-legacy = <0x0>;
> +		ti,itap-del-sel-mmc-hs = <0x0>;
>   		status = "disabled";
>   	};
>   
> @@ -577,17 +576,17 @@ sdhci1: mmc@fa00000 {
>   		clock-names = "clk_ahb", "clk_xin";
>   		bus-width = <4>;
>   		ti,clkbuf-sel = <0x7>;
> -		ti,otap-del-sel-legacy = <0x8>;
> +		ti,otap-del-sel-legacy = <0x0>;
>   		ti,otap-del-sel-sd-hs = <0x0>;
> -		ti,otap-del-sel-sdr12 = <0x0>;
> -		ti,otap-del-sel-sdr25 = <0x0>;
> -		ti,otap-del-sel-sdr50 = <0x8>;
> -		ti,otap-del-sel-sdr104 = <0x7>;
> -		ti,otap-del-sel-ddr50 = <0x4>;
> -		ti,itap-del-sel-legacy = <0xa>;
> -		ti,itap-del-sel-sd-hs = <0x1>;
> -		ti,itap-del-sel-sdr12 = <0xa>;
> -		ti,itap-del-sel-sdr25 = <0x1>;
> +		ti,otap-del-sel-sdr12 = <0xf>;
> +		ti,otap-del-sel-sdr25 = <0xf>;
> +		ti,otap-del-sel-sdr50 = <0xc>;
> +		ti,otap-del-sel-sdr104 = <0x6>;
> +		ti,otap-del-sel-ddr50 = <0x9>;
> +		ti,itap-del-sel-legacy = <0x0>;
> +		ti,itap-del-sel-sd-hs = <0x0>;
> +		ti,itap-del-sel-sdr12 = <0x0>;
> +		ti,itap-del-sel-sdr25 = <0x0>;
>   		status = "disabled";
>   	};
>   
> @@ -600,17 +599,17 @@ sdhci2: mmc@fa20000 {
>   		clock-names = "clk_ahb", "clk_xin";
>   		bus-width = <4>;
>   		ti,clkbuf-sel = <0x7>;
> -		ti,otap-del-sel-legacy = <0x8>;
> +		ti,otap-del-sel-legacy = <0x0>;
>   		ti,otap-del-sel-sd-hs = <0x0>;
> -		ti,otap-del-sel-sdr12 = <0x0>;
> -		ti,otap-del-sel-sdr25 = <0x0>;
> -		ti,otap-del-sel-sdr50 = <0x8>;
> -		ti,otap-del-sel-sdr104 = <0x7>;
> -		ti,otap-del-sel-ddr50 = <0x8>;
> -		ti,itap-del-sel-legacy = <0xa>;
> -		ti,itap-del-sel-sd-hs = <0xa>;
> -		ti,itap-del-sel-sdr12 = <0xa>;
> -		ti,itap-del-sel-sdr25 = <0x1>;
> +		ti,otap-del-sel-sdr12 = <0xf>;
> +		ti,otap-del-sel-sdr25 = <0xf>;
> +		ti,otap-del-sel-sdr50 = <0xc>;
> +		ti,otap-del-sel-sdr104 = <0x6>;
> +		ti,otap-del-sel-ddr50 = <0x9>;
> +		ti,itap-del-sel-legacy = <0x0>;
> +		ti,itap-del-sel-sd-hs = <0x0>;
> +		ti,itap-del-sel-sdr12 = <0x0>;
> +		ti,itap-del-sel-sdr25 = <0x0>;
>   		status = "disabled";
>   	};
>