Hi Markus, kernel test robot noticed the following build errors: [auto build test ERROR on robh/for-next] [also build test ERROR on krzk-dt/for-next linus/master v6.12-rc2 next-20241004] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Markus-Stockhausen/dt-bindings-phy-add-realtek-otto-serdes-PHY-binding/20241008-003929 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next patch link: https://lore.kernel.org/r/20241007163623.3274510-4-markus.stockhausen%40gmx.de patch subject: [PATCH v2 3/3] phy: Integrate Realtek Otto SerDes driver into build system config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20241008/202410081607.EKE62jfx-lkp@xxxxxxxxx/config) compiler: clang version 18.1.8 (https://github.com/llvm/llvm-project 3b5b5c1ec4a3095ab096dd780e84d7ab81f3d7ff) reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241008/202410081607.EKE62jfx-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202410081607.EKE62jfx-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/phy/realtek/phy-rtk-otto-serdes.c:490:15: warning: overlapping comparisons always evaluate to true [-Wtautological-overlap-compare] 490 | if (sid >= 2 || sid <= 9) | ~~~~~~~~~^~~~~~~~~~~ drivers/phy/realtek/phy-rtk-otto-serdes.c:509:15: warning: overlapping comparisons always evaluate to true [-Wtautological-overlap-compare] 509 | if (sid >= 2 || sid <= 9) | ~~~~~~~~~^~~~~~~~~~~ drivers/phy/realtek/phy-rtk-otto-serdes.c:686:6: warning: variable 'ret' is uninitialized when used here [-Wuninitialized] 686 | if (ret) | ^~~ drivers/phy/realtek/phy-rtk-otto-serdes.c:677:9: note: initialize the variable 'ret' to silence this warning 677 | int ret; | ^ | = 0 drivers/phy/realtek/phy-rtk-otto-serdes.c:706:6: warning: variable 'ret' is uninitialized when used here [-Wuninitialized] 706 | if (ret) | ^~~ drivers/phy/realtek/phy-rtk-otto-serdes.c:697:9: note: initialize the variable 'ret' to silence this warning 697 | int ret; | ^ | = 0 drivers/phy/realtek/phy-rtk-otto-serdes.c:723:7: warning: variable 'ret' is uninitialized when used here [-Wuninitialized] 723 | if (!ret) | ^~~ drivers/phy/realtek/phy-rtk-otto-serdes.c:717:9: note: initialize the variable 'ret' to silence this warning 717 | int ret; | ^ | = 0 >> drivers/phy/realtek/phy-rtk-otto-serdes.c:868:1: error: incompatible function pointer types passing 'ssize_t (struct seq_file *, void *)' (aka 'long (struct seq_file *, void *)') to parameter of type 'int (*)(struct seq_file *, void *)' [-Wincompatible-function-pointer-types] 868 | DEFINE_SHOW_STORE_ATTRIBUTE(rtsds_dbg_mode); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/seq_file.h:223:27: note: expanded from macro 'DEFINE_SHOW_STORE_ATTRIBUTE' 223 | return single_open(file, __name ## _show, inode->i_private); \ | ^~~~~~~~~~~~~~~ <scratch space>:49:1: note: expanded from here 49 | rtsds_dbg_mode_show | ^~~~~~~~~~~~~~~~~~~ include/linux/seq_file.h:176:38: note: passing argument to parameter here 176 | int single_open(struct file *, int (*)(struct seq_file *, void *), void *); | ^ drivers/phy/realtek/phy-rtk-otto-serdes.c:891:1: error: incompatible function pointer types passing 'ssize_t (struct seq_file *, void *)' (aka 'long (struct seq_file *, void *)') to parameter of type 'int (*)(struct seq_file *, void *)' [-Wincompatible-function-pointer-types] 891 | DEFINE_SHOW_STORE_ATTRIBUTE(rtsds_dbg_reset); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ include/linux/seq_file.h:223:27: note: expanded from macro 'DEFINE_SHOW_STORE_ATTRIBUTE' 223 | return single_open(file, __name ## _show, inode->i_private); \ | ^~~~~~~~~~~~~~~ <scratch space>:54:1: note: expanded from here 54 | rtsds_dbg_reset_show | ^~~~~~~~~~~~~~~~~~~~ include/linux/seq_file.h:176:38: note: passing argument to parameter here 176 | int single_open(struct file *, int (*)(struct seq_file *, void *), void *); | ^ 5 warnings and 2 errors generated. Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for MODVERSIONS Depends on [n]: MODULES [=y] && !COMPILE_TEST [=y] Selected by [y]: - RANDSTRUCT_FULL [=y] && (CC_HAS_RANDSTRUCT [=y] || GCC_PLUGINS [=n]) && MODULES [=y] vim +868 drivers/phy/realtek/phy-rtk-otto-serdes.c 40f1aea80b53b8 Markus Stockhausen 2024-10-07 847 40f1aea80b53b8 Markus Stockhausen 2024-10-07 848 static ssize_t rtsds_dbg_mode_write(struct file *file, const char __user *userbuf, 40f1aea80b53b8 Markus Stockhausen 2024-10-07 849 size_t count, loff_t *ppos) 40f1aea80b53b8 Markus Stockhausen 2024-10-07 850 { 40f1aea80b53b8 Markus Stockhausen 2024-10-07 851 struct seq_file *seqf = file->private_data; 40f1aea80b53b8 Markus Stockhausen 2024-10-07 852 struct rtsds_macro *macro = dev_get_drvdata(seqf->private); 40f1aea80b53b8 Markus Stockhausen 2024-10-07 853 struct rtsds_ctrl *ctrl = macro->ctrl; 40f1aea80b53b8 Markus Stockhausen 2024-10-07 854 int ret, hwmode, phymode, sid = macro->sid; 40f1aea80b53b8 Markus Stockhausen 2024-10-07 855 40f1aea80b53b8 Markus Stockhausen 2024-10-07 856 ret = kstrtou32_from_user(userbuf, count, 16, &hwmode); 40f1aea80b53b8 Markus Stockhausen 2024-10-07 857 if (ret) 40f1aea80b53b8 Markus Stockhausen 2024-10-07 858 return ret; 40f1aea80b53b8 Markus Stockhausen 2024-10-07 859 /* 40f1aea80b53b8 Markus Stockhausen 2024-10-07 860 * Allow to set arbitrary modes into the SerDes to improve error analysis. Accept that 40f1aea80b53b8 Markus Stockhausen 2024-10-07 861 * this might confuse the internal state tracking. 40f1aea80b53b8 Markus Stockhausen 2024-10-07 862 */ 40f1aea80b53b8 Markus Stockhausen 2024-10-07 863 phymode = rtsds_hwmode_to_phymode(ctrl, hwmode); 40f1aea80b53b8 Markus Stockhausen 2024-10-07 864 rtsds_phy_set_mode_int(ctrl, sid, phymode, hwmode); 40f1aea80b53b8 Markus Stockhausen 2024-10-07 865 40f1aea80b53b8 Markus Stockhausen 2024-10-07 866 return count; 40f1aea80b53b8 Markus Stockhausen 2024-10-07 867 } 40f1aea80b53b8 Markus Stockhausen 2024-10-07 @868 DEFINE_SHOW_STORE_ATTRIBUTE(rtsds_dbg_mode); 40f1aea80b53b8 Markus Stockhausen 2024-10-07 869 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
