On Mon, Oct 07, 2024 at 10:44:46AM -0500, Rob Herring wrote: > On Mon, Oct 07, 2024 at 04:29:20PM +0200, Francesco Dolcini wrote: > > On Mon, Oct 07, 2024 at 09:16:48AM -0500, Rob Herring (Arm) wrote: > > > On Mon, 07 Oct 2024 11:32:04 +0200, Francesco Dolcini wrote: > > > > From: Parth Pancholi <parth.pancholi@xxxxxxxxxxx> > > > > > > > > Add device tree bindings for TI's TUSB73x0 PCIe-to-USB 3.0 xHCI > > > > host controller. The controller supports software configuration > > > > through PCIe registers, such as controlling the PWRONx polarity > > > > via the USB control register (E0h). > > > > > > > > Similar generic PCIe-based bindings can be found as qcom,ath11k-pci.yaml > > > > as an example. > > > > > > > > Datasheet: https://www.ti.com/lit/ds/symlink/tusb7320.pdf > > > > Signed-off-by: Parth Pancholi <parth.pancholi@xxxxxxxxxxx> > > > > Signed-off-by: Francesco Dolcini <francesco.dolcini@xxxxxxxxxxx> > > > > --- > > > > v2: rename property to ti,tusb7320-pwron-active-high and change type to flag > > > > --- > > > > .../bindings/usb/ti,tusb73x0-pci.yaml | 60 +++++++++++++++++++ > > > > 1 file changed, 60 insertions(+) > > > > create mode 100644 Documentation/devicetree/bindings/usb/ti,tusb73x0-pci.yaml > > > > > > > > > > My bot found errors running 'make dt_binding_check' on your patch: > > > > > > yamllint warnings/errors: > > > > > > dtschema/dtc warnings/errors: > > > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/usb/ti,tusb73x0-pci.example.dtb: pcie@0: usb@0:compatible: ['pci104C,8241'] does not contain items matching the given schema > > > from schema $id: http://devicetree.org/schemas/pci/pci-bus-common.yaml# > > > > > > doc reference errors (make refcheckdocs): > > > > > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20241007093205.27130-2-francesco@xxxxxxxxxx > > > > > > The base for the series is generally the latest rc1. A different dependency > > > should be noted in *this* patch. > > > > > > If you already ran 'make dt_binding_check' and didn't see the above > > > error(s), then make sure 'yamllint' is installed and dt-schema is up to > > > date: > > > > > > pip3 install dtschema --upgrade > > > > I do not have this error locally, and I am not sure I see the issue in > > the yaml file ... > > > > $ make dt_binding_check W=1 DT_SCHEMA_FILES=ti,tusb73x0-pci.yaml > > DT_SCHEMA_FILES limits what is tested. > > The issue is your compatible string should be lowercase hex. Whoops, thanks for helping out. I'll wait for more feedback (on this, and on patch 2/2) before sending a v3, let me know if there is anything else that would need to be adjusted. Francesco
