Re: [PATCH 2/2] ARM: dts: mediatek: mt7623: fix efuse fallback compatible

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





On 17/06/2024 11:46, Rafał Miłecki wrote:
From: Rafał Miłecki <rafal@xxxxxxxxxx>

Fix following validation error:
arch/arm/boot/dts/mediatek/mt7623a-rfb-emmc.dtb: efuse@10206000: compatible: 'oneOf' conditional failed, one must be fixed:
         ['mediatek,mt7623-efuse', 'mediatek,mt8173-efuse'] is too long
         'mediatek,mt8173-efuse' was expected
         'mediatek,efuse' was expected
         from schema $id: http://devicetree.org/schemas/nvmem/mediatek,efuse.yaml#
arch/arm/boot/dts/mediatek/mt7623a-rfb-emmc.dtb: efuse@10206000: Unevaluated properties are not allowed ('compatible' was unexpected)
         from schema $id: http://devicetree.org/schemas/nvmem/mediatek,efuse.yaml#

Fixes: 43c7a91b4b3a ("arm: dts: mt7623: add efuse nodes to the mt7623.dtsi file")
Signed-off-by: Rafał Miłecki <rafal@xxxxxxxxxx>
---
  arch/arm/boot/dts/mediatek/mt7623.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/mediatek/mt7623.dtsi b/arch/arm/boot/dts/mediatek/mt7623.dtsi
index 9c5a52ce9351..748f9b366897 100644
--- a/arch/arm/boot/dts/mediatek/mt7623.dtsi
+++ b/arch/arm/boot/dts/mediatek/mt7623.dtsi
@@ -328,7 +328,7 @@ sysirq: interrupt-controller@10200100 {
efuse: efuse@10206000 {
  		compatible = "mediatek,mt7623-efuse",
-			     "mediatek,mt8173-efuse";
+			     "mediatek,efuse";

Angelo stated that we should move away from generic fallbacks. Although the binding states explicitly to use "mediatek,efuse" and deprecates the standalone "mediate,mt8173-efuse", which could the default fallback. Angelo, what do you think, take it or re-doing the binding first?

Regards,
Matthias

  		reg = <0 0x10206000 0 0x1000>;
  		#address-cells = <1>;
  		#size-cells = <1>;




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux