On Fri, Oct 4, 2024 at 4:06 PM Bjorn Andersson <quic_bjorande@xxxxxxxxxxx> wrote: > > On Tue, Oct 01, 2024 at 10:35:30AM +0200, Bartosz Golaszewski wrote: > > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > > > The Inline Crypto Engine (ICE) for UFS/EMMC supports the Hardware Key > > Manager (HWKM) to securely manage storage keys. Enable using this > > hardware on sm8650. > > > > This requires us to increase the register range: HWKM is an additional > > piece of hardware sitting alongside ICE, and extends the old ICE's > > register space. > > > > This commit message doesn't follow what Neil requested in v5: > > https://lore.kernel.org/lkml/109b1e46-f46f-4636-87d5-66266e04ccff@xxxxxxxxxx/ > Because we have dropped the new property two versions ago as per this series' cover letter. > > Reviewed-by: Om Prakash Singh <quic_omprsing@xxxxxxxxxxx> > > Tested-by: Neil Armstrong <neil.armstrong@xxxxxxxxxx> > > I unfortunately can't find where Neil provided this. > > Is this tag referring to this patch having been tested together with the > driver changes, so he's saying that HWKM works fine. Or is he saying > that the old feature set still works after the growth of the register > region (i.e. what he requested in v5)? > I think Neil tested the full functionality of HWKM on sm8650 as per Gaurav's instructions. I did the same as well. Bart
