Hi Krzysztof, Thank you for the review. > > On Thu, Oct 03, 2024 at 09:15:06PM +0530, Neeraj Sanjay Kale wrote: > > This adds a new optional device tree property h2c-ps-gpios, which > > specifies the GPIO connected to BT_WAKE_IN pin of the NXP chipset. > > > > If this property is defined, the driver will use this GPIO for driving > > chip into sleep/wakeup state, else use the UART break signal by default. > > > > Signed-off-by: Neeraj Sanjay Kale <neeraj.sanjaykale@xxxxxxx> > > --- > > v2: Rephrase description and use "-gpios". (Krzysztof, Rob) > > --- > > .../devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml | 8 > > ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git > > a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > > b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > > index 37a65badb448..cd8236eb31de 100644 > > --- > > a/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.yaml > > +++ b/Documentation/devicetree/bindings/net/bluetooth/nxp,88w8987-bt.y > > +++ aml > > @@ -34,6 +34,12 @@ properties: > > firmware-name: > > maxItems: 1 > > > > + h2c-ps-gpios: > > + maxItems: 1 > > + description: > > + Host-To-Chip power save mechanism is driven by this GPIO > > + connected to BT_WAKE_IN pin of the NXP chipset. > > So this should be wakeup-gpios or device-wakeup-gpios? > Yes, if that's the preferred name, let me quickly change it to device-wakeup-gpios. There may be a different feature implementation in near future for host wake-up. So wakeup-gpios may seem confusing then. Thanks, Neeraj
