Re: [PATCH v2 2/4] media: dt-bindings: Add OmniVision OV08X40

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 01/10/2024 14:22, Sakari Ailus wrote:
+  assigned-clocks: true
+  assigned-clock-parents: true
+  assigned-clock-rates: true
As much as I'd like to see these mandatory, there seem to be cases where
they can't be used. Therefore I'd leave them in the example only.

If that turns out to be the only change to do, I can also handle that while
applying.

So I took Documentation/devicetree/bindings/media/i2c/ovti,ov9282.yaml as the reference for this.

Without listing "assigned-clock*" in the required: field I believe the dts checkers will not require those.

So instead of saying
assigned-clocks:
    maxItems: 1

we write
assigned-clocks: true

omit from "required:" and get the desired effect.

For example this passes the checker for me.

&cci1_i2c1 {
        camera@36 {
                compatible = "ovti,ov08x40";
                reg = <0x36>;

                reset-gpios = <&tlmm 237 GPIO_ACTIVE_LOW>;
                pinctrl-names = "default";
                pinctrl-0 = <&cam_rgb_default>;

                clocks = <&camcc CAM_CC_MCLK4_CLK>;
                assigned-clocks = <&camcc CAM_CC_MCLK4_CLK>;
                assigned-clock-rates = <19200000>;

                orientation = <0>; /* front facing */

                avdd-supply = <&vreg_l7b_2p8>;
                dvdd-supply = <&vreg_l7b_2p8>;
                dovdd-supply = <&vreg_l3m_1p8>;

                port {
                        ov08x40_ep: endpoint {
                                clock-lanes = <0>;
                                data-lanes = <1 2 3 4>;
                                link-frequencies = /bits/ 64 <400000000>;
                                remote-endpoint = <&csiphy4_ep>;
                        };
                };
        };
};

Eh.. at least that's how I think this works.

Krzysztof/Rob ?

---
bod




[Index of Archives]     [Device Tree Compilter]     [Device Tree Spec]     [Linux Driver Backports]     [Video for Linux]     [Linux USB Devel]     [Linux PCI Devel]     [Linux Audio Users]     [Linux Kernel]     [Linux SCSI]     [XFree86]     [Yosemite Backpacking]


  Powered by Linux