On Thu, Sep 26, 2024 at 04:31:33PM +0530, Mahadevan wrote: > Document the MDSS hardware found on the Qualcomm SA8775P platform. > > Signed-off-by: Mahadevan <quic_mahap@xxxxxxxxxxx> > --- > > [v2] > - Use fake DISPCC nodes to avoid clock dependencies in dt-bindings. [Dmitry] > - Update bindings by fixing dt_binding_check tool errors (update includes in example), > adding proper spacing and indentation in binding example, dropping unused labels, > dropping status disable, adding reset node. [Dmitry, Rob, Krzysztof] No concerns with the changelog, but please adopt b4 (go/upstream has instructions) for sending patches upstream. > > --- > .../display/msm/qcom,sa8775p-mdss.yaml | 239 ++++++++++++++++++ > 1 file changed, 239 insertions(+) > create mode 100644 Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml > > diff --git a/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml > new file mode 100644 > index 000000000000..e610b66ffa9f > --- /dev/null > +++ b/Documentation/devicetree/bindings/display/msm/qcom,sa8775p-mdss.yaml > @@ -0,0 +1,239 @@ > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/display/msm/qcom,sa8775p-mdss.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Qualcomm Technologies, Inc. SA87755P Display MDSS > + > +maintainers: > + - Mahadevan <quic_mahap@xxxxxxxxxxx> Please use Firstname Lastname, if possible > + > +description: > + SA8775P MSM Mobile Display Subsystem(MDSS), which encapsulates sub-blocks like > + DPU display controller, DP interfaces and EDP etc. > + > +$ref: /schemas/display/msm/mdss-common.yaml# > + [..] > + > +examples: > + - | > + #include <dt-bindings/interconnect/qcom,icc.h> > + #include <dt-bindings/interrupt-controller/arm-gic.h> > + #include <dt-bindings/clock/qcom,sa8775p-gcc.h> > + #include <dt-bindings/interconnect/qcom,sa8775p-rpmh.h> > + #include <dt-bindings/power/qcom,rpmhpd.h> > + #include <dt-bindings/power/qcom-rpmpd.h> > + > + display-subsystem@ae00000 { > + compatible = "qcom,sa8775p-mdss"; > + reg = <0 0x0ae00000 0 0x1000>; #address-cells and #size-cells are 1 in the example root node, so drop the two 0 entries. > + reg-names = "mdss"; > + > + /* same path used twice */ What do you mean? All three paths below are unique. > + interconnects = <&mmss_noc MASTER_MDP0 0 &mc_virt SLAVE_EBI1 0>, > + <&mmss_noc MASTER_MDP1 0 &mc_virt SLAVE_EBI1 0>, > + <&gem_noc MASTER_APPSS_PROC QCOM_ICC_TAG_ACTIVE_ONLY > + &config_noc SLAVE_DISPLAY_CFG QCOM_ICC_TAG_ACTIVE_ONLY>; > + interconnect-names = "mdp0-mem", > + "mdp1-mem", > + "cpu-cfg"; > + > + Regards, Bjorn
