Hi, > @@ -7611,10 +7650,13 @@ struct tcpm_port *tcpm_register_port(struct device *dev, struct tcpc_dev *tcpc) > err = tcpm_fw_get_caps(port, tcpc->fwnode); > if (err < 0) > goto out_destroy_wq; > + This extra newline is not relevant or necessary. Otherwise this LGTM: Reviewed-by: Heikki Krogerus <heikki.krogerus@xxxxxxxxxxxxxxx> > err = tcpm_fw_get_snk_vdos(port, tcpc->fwnode); > if (err < 0) > goto out_destroy_wq; > > + tcpm_fw_get_timings(port, tcpc->fwnode); > + > port->try_role = port->typec_caps.prefer_role; > > port->typec_caps.revision = 0x0120; /* Type-C spec release 1.2 */ thanks, -- heikki
