Re: [PATCH v3 4/4] arm64: dts: imx8mp-iota2: Enable the USB Type-C port

[Michal Vokáč <michal.vokac@xxxxxxxxx>]

On 24. 09. 24 9:23, Marco Felsch wrote:
> On 24-09-23, Michal Vokáč wrote:
> > From: Petr Benes <petr.benes@xxxxxxxxx>
> >
> > Enable the USB Type-C port with the Diodes PI5USB30213A port controller.
> > The port supports dual role data but can operate only in source power role
> > and PD is not supported.
> >
> > Signed-off-by: Petr Benes <petr.benes@xxxxxxxxx>
> > Signed-off-by: Michal Vokáč <michal.vokac@xxxxxxxxx>
> > ---
> > v3:
> > - none
> > v2:
> > - Use typec instead of tcpc.
> > - Drop unneeded status.
> >
> >   .../boot/dts/freescale/imx8mp-iota2-lumpy.dts | 94 +++++++++++++++++++
> >   1 file changed, 94 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/freescale/imx8mp-iota2-lumpy.dts b/arch/arm64/boot/dts/freescale/imx8mp-iota2-lumpy.dts
> > index 120e6b87a000..bfed410339a4 100644
> > --- a/arch/arm64/boot/dts/freescale/imx8mp-iota2-lumpy.dts
> > +++ b/arch/arm64/boot/dts/freescale/imx8mp-iota2-lumpy.dts
> > @@ -32,6 +32,17 @@ button-reset {
> >   		};
> >   	};
> >   
> > +	reg_typec: regulator-typec {
> > +		compatible = "regulator-fixed";
> > +		enable-active-high;
> > +		gpio = <&gpio1 12 GPIO_ACTIVE_HIGH>;
>
> Can you please put the enable-active-high and gpio property below the
> regualtor-* properties?

Sure.

> > +		pinctrl-0 = <&pinctrl_usbc_vbus>;
> > +		pinctrl-names = "default";
> > +		regulator-max-microvolt = <5000000>;
> > +		regulator-min-microvolt = <5000000>;
> > +		regulator-name = "typec";
> > +	};
> > +
> >   	reg_usb_host: regulator-usb-host {
> >   		compatible = "regulator-fixed";
> >   		enable-active-high;

> > @@ -389,15 +451,47 @@ &uart2 {
> >   	status = "okay";
> >   };
> >   
> > +&usb3_0 {
> > +	status = "okay";
> > +};
> > +
> >   &usb3_1 {
> >   	status = "okay";
> >   };
> >   
> > +&usb3_phy0 {
> > +	status = "okay";
> > +};
> > +
> >   &usb3_phy1 {
> >   	vbus-supply = <&reg_usb_host>;
> >   	status = "okay";
> >   };
> >   
> > +&usb_dwc3_0 {
> > +	#address-cells = <1>;
> > +	#size-cells = <0>;
> > +	dr_mode = "otg";
> > +	usb-role-switch;
> > +	status = "okay";
> > +
>
> 	ports {
> 		#address-cells = <1>;
> 		#size-cells = <0>;

OK.

> > +	port@0 {
> > +		reg = <0>;
> > +
> > +		typec_hs: endpoint {
> > +			remote-endpoint = <&usb_con_hs>;
> > +		};
> > +	};
> > +
> > +	port@1 {
> > +		reg = <1>;
> > +
> > +		typec_ss: endpoint {
> > +			remote-endpoint = <&usb_con_ss>;
> > +		};
> > +	};
>
> 	}
>
> 	like you did for the connector node.

OK, I will do so.
Thank you for the review,
Michal