On Tue, Sep 17, 2024 at 02:36:30PM GMT, Sachin Gupta wrote:
> Add SD Card node for Qualcomm qcs6490-rb3gen2 Board.
Consider adding mmc0 or mmc2 alias for the sdhc_2 node.
> Signed-off-by: Sachin Gupta <quic_sachgupt@xxxxxxxxxxx>
> ---
> arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 33 ++++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> index 0d45662b8028..5df3167651ca 100644
> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> @@ -716,9 +716,42 @@
> status = "okay";
> };
>
> +&sdc2_clk {
> + bias-disable;
> + drive-strength = <16>;
> +};
Please move all pinctrl-related nodes below the PINCTRL comment.
> +
> +&sdc2_cmd {
> + bias-pull-up;
> + drive-strength = <10>;
> +};
> +
> +&sdc2_data {
> + bias-pull-up;
> + drive-strength = <10>;
> +};
> +
> +&sdhc_2 {
> + status = "okay";
> +
> + pinctrl-0 = <&sdc2_clk>, <&sdc2_cmd>, <&sdc2_data>, <&sd_cd>;
> + pinctrl-1 = <&sdc2_clk_sleep>, <&sdc2_cmd_sleep>, <&sdc2_data_sleep>, <&sd_cd>;
> +
> + vmmc-supply = <&vreg_l9c_2p96>;
> + vqmmc-supply = <&vreg_l6c_2p96>;
> +
> + cd-gpios = <&tlmm 91 GPIO_ACTIVE_LOW>;
> +};
> +
> &tlmm {
> gpio-reserved-ranges = <32 2>, /* ADSP */
> <48 4>; /* NFC */
> +
> + sd_cd: sd-cd-state {
> + pins = "gpio91";
> + function = "gpio";
> + bias-pull-up;
> + };
There is also a special PINCRTL_related TLMM imstance down the file,
move it to that node.
> };
>
> &uart5 {
> --
> 2.17.1
>
--
With best wishes
Dmitry
