On 10/09/2024 10:20, Delphine_CC_Chiu/WYHQ/Wiwynn wrote: > I will revise in v2. Thanks! >>> + interrupt-parent = <&gpio0>; >>> + interrupts = <98 IRQ_TYPE_LEVEL_LOW>; >>> + gpio-line-names = >>> + "P48V_OCP_GPIO1","P48V_OCP_GPIO2", >> >> Nothing improved here. I already commented about above and this. >> Implement feedback for all your patches, not only one. >> >> Best regards, >> Krzysztof > Sorry about that. > I saw you say "Broken alignment" in v15 patch. > Would like to ask if the following format meets your expectations? > + gpio-line-names = > + "P48V_OCP_GPIO1", "P48V_OCP_GPIO2", > + "P48V_OCP_GPIO3", "FAN_BOARD_0_REVISION_0_R", Please read DTS coding style before posting next version of the patch (or any patch for DTS). This is still not aligned. There is (almost) never a blank line after '='. Best regards, Krzysztof
