On 2024/9/12 10:30, Chukun Pan wrote:
> Hi Junhao,
>
>> ...
>> --- /dev/null
>> +++ b/arch/arm64/boot/dts/rockchip/rk3568-photonicat.dts
>> ...
>
>> + rfkill-modem {
>> + compatible = "rfkill-gpio";
>> + label = "M.2 USB Modem";
>> + radio-type = "wwan";
>> + reset-gpios = <&gpio0 RK_PB0 GPIO_ACTIVE_LOW>;
>> + shutdown-gpios = <&gpio4 RK_PC4 GPIO_ACTIVE_HIGH>;
>> + };
>
> gpio0 RK_PB0 conflicts with xin32k, please add:
>
> &xin32k {
> pinctrl-names = "default";
> pinctrl-0 = <&clk32k_out1>;
> };
I added it and it currently works fine
>
>> + vccin_5v: regulator-5v0-vcc-in {
>> + vcc_sysin: regulator-5v0-vcc-sysin {
>> + vcc_syson: regulator-5v0-vcc-syson {
>> + vcc5v0_usb30_otg0: regulator-5v0-vcc-usb-host {
>
> obviously (
I seem to have misunderstood the rules in dt-bindings before.
The following looks better:
vcc5v0_usb30_otg0: regulator-vcc5v0-usb30-otg0 {
vccin_5v: regulator-vccin-5v {
vcc_sysin: regulator-vcc-sysin {
vcc_syson: regulator-vcc-syson {
>
Thanks for your review, I will fix all problems in next version!
Best regards,
Junhao
