On Wed, Sep 11, 2024 at 07:15:33PM +0300, Andy Shevchenko wrote: > On Wed, Sep 11, 2024 at 06:02:53PM +0200, Vasileios Amoiridis wrote: > > Resources definition can become simpler and more organised by using the > > dedicated helpers. > > ... > > > - r->start = r->end = irq; > > - r->flags = IORESOURCE_IRQ | irq_get_trigger_type(irq); > > - r->name = name ? name : of_node_full_name(dev); > > + *r = DEFINE_RES_IRQ_NAMED(irq, name ? name : of_node_full_name(dev)); > > Hmm... It seems you haven't replied to me why you avoid using Elvis here, > while at it. > > Also for both patches you probably want > Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > > > + r->flags |= irq_get_trigger_type(irq); > > -- > With Best Regards, > Andy Shevchenko > > Hi Andy, Thanks for your message once again!! I honestly didn't know this operator, I just found out about it. Looks like it fits here, I can definitely use it. I am going to leave it for a while to see if Krzysztof or Rob have any other comments and then I can send as you proposed. As for the tag, of course I can add it! I just wasn't sure if that was the case for here. Cheers, Vasilis
