On Wed, Sep 11, 2024 at 06:02:53PM +0200, Vasileios Amoiridis wrote: > Resources definition can become simpler and more organised by using the > dedicated helpers. ... > - r->start = r->end = irq; > - r->flags = IORESOURCE_IRQ | irq_get_trigger_type(irq); > - r->name = name ? name : of_node_full_name(dev); > + *r = DEFINE_RES_IRQ_NAMED(irq, name ? name : of_node_full_name(dev)); Hmm... It seems you haven't replied to me why you avoid using Elvis here, while at it. Also for both patches you probably want Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> > + r->flags |= irq_get_trigger_type(irq); -- With Best Regards, Andy Shevchenko
