On Wed 11 Sep 2024 at 09:45, Rob Herring <robh@xxxxxxxxxx> wrote: > gOn Tue, Sep 10, 2024 at 11:31:18AM +0200, Jerome Brunet wrote: >> On Tue 10 Sep 2024 at 09:48, Krzysztof Kozlowski <krzk@xxxxxxxxxx> wrote: >> >> > On Mon, Sep 09, 2024 at 05:39:03PM +0200, Jerome Brunet wrote: >> >> Add DT binding documentation for the Texas Instruments TPS25990 eFuse >> >> >> >> Signed-off-by: Jerome Brunet <jbrunet@xxxxxxxxxxxx> >> >> --- >> >> .../bindings/hwmon/pmbus/ti,tps25990.yaml | 73 ++++++++++++++++++++++ >> >> 1 file changed, 73 insertions(+) >> >> >> > >> > A nit, subject: drop second/last, redundant "documentation". The >> > "dt-bindings" prefix is already stating that these are bindings/docs. >> > See also: >> > https://elixir.bootlin.com/linux/v6.7-rc8/source/Documentation/devicetree/bindings/submitting-patches.rst#L18 >> > >> >> diff --git a/Documentation/devicetree/bindings/hwmon/pmbus/ti,tps25990.yaml b/Documentation/devicetree/bindings/hwmon/pmbus/ti,tps25990.yaml >> >> new file mode 100644 >> >> index 000000000000..e717942b3598 >> >> --- /dev/null >> >> +++ b/Documentation/devicetree/bindings/hwmon/pmbus/ti,tps25990.yaml >> >> @@ -0,0 +1,73 @@ >> >> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause) >> >> +%YAML 1.2 >> >> +--- >> >> + >> > >> > Drop blank line. >> > >> >> +$id: http://devicetree.org/schemas/hwmon/pmbus/ti,tps25990.yaml# >> >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> >> + >> >> +title: Texas Instruments TPS25990 Stackable eFuse >> >> + >> >> +maintainers: >> >> + - Jerome Brunet <jbrunet@xxxxxxxxxxxx> >> >> + >> >> +description: | >> > >> > Do not need '|' unless you need to preserve formatting. >> > >> >> + The TI TPS25990 is an integrated, high-current circuit >> >> + protection and power management device with PMBUS interface > > And wrap at 80. > >> >> + >> >> +properties: >> >> + compatible: >> >> + const: ti,tps25990 >> >> + >> >> + reg: >> >> + maxItems: 1 >> >> + >> >> + ti,rimon-milli-ohms: >> >> + description: >> >> + milli Ohms value of the resistance installed between the Imon pin >> >> + and the ground reference. >> > >> > Ohms is not enough? We don't have mOhm in property units. >> > https://github.com/devicetree-org/dt-schema/blob/main/dtschema/schemas/property-units.yaml >> > >> >> Same discussion as we've had on the driver change. >> At the moment Ohms is enough for the cases I've seen. >> >> Will it be, not sure. >> Using mOhms is' way to avoid "S**t, R is 80.2 Ohms, I >> need another digit to not loose precision " kind of situation and >> introduce a second property just for that. >> >> No idea if Rimon will get that low. Probably not. >> >> I'll switch to Ohms. > > You can can use "-micro-ohms" too. The reason we don't have every > possible unit is so we have everyone picking their own. Noted. after discussing with Guenter, I'll use micro-ohms in the next version, not ohms > > Rob -- Jerome
