On 9/10/24 08:18, Stanimir Varbanov wrote:
On brcm_pcie_turn_off avoid shutdown of bridge reset.
Signed-off-by: Stanimir Varbanov <svarbanov@xxxxxxx>
---
drivers/pci/controller/pcie-brcmstb.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)
diff --git a/drivers/pci/controller/pcie-brcmstb.c b/drivers/pci/controller/pcie-brcmstb.c
index d78f33b33884..185ccf7fe86a 100644
--- a/drivers/pci/controller/pcie-brcmstb.c
+++ b/drivers/pci/controller/pcie-brcmstb.c
@@ -234,10 +234,17 @@ struct inbound_win {
u64 cpu_addr;
};
+/*
+ * Shutting down this bridge on pcie1 means accesses to rescal block
+ * will hang the chip if another RC wants to assert/deassert rescal.
+ */
Maybe a slightly more detailed comment saying that the RESCAL block is
tied to PCIe controller #1, regardless of the number of controllers, and
turning off PCIe controller #1 prevents access to the RESCAL register
blocks, therefore not other controller can access this register space,
and depending upon the bus fabric we may get a timeout (UBUS/GISB), or a
hang (AXI).
Thanks!
--
Florian
