Hi Vasileios, kernel test robot noticed the following build errors: [auto build test ERROR on ecc768a84f0b8e631986f9ade3118fa37852fef0] url: https://github.com/intel-lab-lkp/linux/commits/Vasileios-Amoiridis/of-irq-Make-use-of-irq_get_trigger_type/20240905-000607 base: ecc768a84f0b8e631986f9ade3118fa37852fef0 patch link: https://lore.kernel.org/r/20240904160239.121301-3-vassilisamir%40gmail.com patch subject: [PATCH v2 2/2] of/irq: Use helper to define resources config: i386-allyesconfig (https://download.01.org/0day-ci/archive/20240908/202409080202.QLS8E1DK-lkp@xxxxxxxxx/config) compiler: gcc-12 (Debian 12.2.0-14) 12.2.0 reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240908/202409080202.QLS8E1DK-lkp@xxxxxxxxx/reproduce) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot <lkp@xxxxxxxxx> | Closes: https://lore.kernel.org/oe-kbuild-all/202409080202.QLS8E1DK-lkp@xxxxxxxxx/ All errors (new ones prefixed by >>): drivers/of/irq.c: In function 'of_irq_to_resource': >> drivers/of/irq.c:433:17: error: expected ';' before 'r' 433 | r->flags |= irq_get_trigger_type(irq); | ^ Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for OMAP2PLUS_MBOX Depends on [n]: MAILBOX [=y] && (ARCH_OMAP2PLUS || ARCH_K3) Selected by [y]: - TI_K3_M4_REMOTEPROC [=y] && REMOTEPROC [=y] && (ARCH_K3 || COMPILE_TEST [=y]) vim +433 drivers/of/irq.c 405 406 /** 407 * of_irq_to_resource - Decode a node's IRQ and return it as a resource 408 * @dev: pointer to device tree node 409 * @index: zero-based index of the irq 410 * @r: pointer to resource structure to return result into. 411 */ 412 int of_irq_to_resource(struct device_node *dev, int index, struct resource *r) 413 { 414 int irq = of_irq_get(dev, index); 415 416 if (irq < 0) 417 return irq; 418 419 /* Only dereference the resource if both the 420 * resource and the irq are valid. */ 421 if (r && irq) { 422 const char *name = NULL; 423 424 memset(r, 0, sizeof(*r)); 425 /* 426 * Get optional "interrupt-names" property to add a name 427 * to the resource. 428 */ 429 of_property_read_string_index(dev, "interrupt-names", index, 430 &name); 431 432 *r = DEFINE_RES_IRQ_NAMED(irq, name ? name : of_node_full_name(dev)) > 433 r->flags |= irq_get_trigger_type(irq); 434 } 435 436 return irq; 437 } 438 EXPORT_SYMBOL_GPL(of_irq_to_resource); 439 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki
