On Thu, Sep 05, 2024 at 07:14:49PM -0500, Rob Herring (Arm) wrote: > > On Fri, 06 Sep 2024 01:52:59 +0300, Laurent Pinchart wrote: > > Add device tree binding for the onsemi AR0144 CMOS camera sensor. The > > binding supports both the monochrome and color sensor versions. > > > > Signed-off-by: Laurent Pinchart <laurent.pinchart@xxxxxxxxxxxxxxxx> > > --- > > Changes since v1: > > > > - Drop clock-names > > - Rename vdd_io-supply to vddio supply > > - Drop unnecessary | > > --- > > .../bindings/media/i2c/onnn,ar0144.yaml | 162 ++++++++++++++++++ > > MAINTAINERS | 6 + > > 2 files changed, 168 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/media/i2c/onnn,ar0144.yaml > > > > My bot found errors running 'make dt_binding_check' on your patch: > > yamllint warnings/errors: > > dtschema/dtc warnings/errors: > /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/media/i2c/onnn,ar0144.example.dtb: camera@10: 'clock-names' is a required property > from schema $id: http://devicetree.org/schemas/media/i2c/onnn,ar0144.yaml# My bad, I forgot to retest before sending v2 :( Sorry about that. It will be fixed (and tested) in v3. > doc reference errors (make refcheckdocs): > > See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240905225308.11267-2-laurent.pinchart@xxxxxxxxxxxxxxxx > > The base for the series is generally the latest rc1. A different dependency > should be noted in *this* patch. > > If you already ran 'make dt_binding_check' and didn't see the above > error(s), then make sure 'yamllint' is installed and dt-schema is up to > date: > > pip3 install dtschema --upgrade > > Please check and re-submit after running the above command yourself. Note > that DT_SCHEMA_FILES can be set to your schema file to speed up checking > your schema. However, it must be unset to test all examples with your schema. -- Regards, Laurent Pinchart