Hi Andi,
On 05.09.24 22:20, Andi Shyti wrote:
Hi,
On Wed, Sep 04, 2024 at 10:59:47AM GMT, Peter Rosin wrote:
2024-09-04 at 10:35, Farouk Bouabid wrote:
On 03.09.24 17:13, Andi Shyti wrote:
[...]
+ ret = i2c_mux_add_adapter(muxc, 0, reg);
+ if (ret)
+ return ret;
do we need to delete the adapters we added in previous cycles?
We calldevm_action_or_reset() before the loop to add adapter-removal to the error path. I think that does the job
for us or am I missing something ?
I missed that too, but it LGTM. It's safe to call i2c_mux_del_adapters() as
soon the mux core has been allocated, so there is no risk it is called too
early or something.
Just a question, still: is it the same calling
i2c_mux_add_adapter() and calling mux_remove()?
We are basically wrapping i2c_mux_adapters_del() by mux_remove()
(implemented in our driver) which is registered it as
devm_add_action_or_reset and would be called for a non-0 return of the
probe. i2c_mux_adapters_del() will then remove added adapters (do
nothing if none is added).
Thanks,
Farouk
