Hi, On Wed, Sep 04, 2024 at 10:59:47AM GMT, Peter Rosin wrote: > 2024-09-04 at 10:35, Farouk Bouabid wrote: > > On 03.09.24 17:13, Andi Shyti wrote: > > > > [...] > > > >>> + ret = i2c_mux_add_adapter(muxc, 0, reg); > >>> + if (ret) > >>> + return ret; > >> do we need to delete the adapters we added in previous cycles? > >> > > > > We calldevm_action_or_reset() before the loop to add adapter-removal to the error path. I think that does the job > > > > for us or am I missing something ? > > I missed that too, but it LGTM. It's safe to call i2c_mux_del_adapters() as > soon the mux core has been allocated, so there is no risk it is called too > early or something. Just a question, still: is it the same calling i2c_mux_add_adapter() and calling mux_remove()? Thanks, Andi > With that said, I agree with Andi on the naming and the > nitpicks. > > Cheers, > Peter
