Hi Drew, thanks for your patch! On Tue, Sep 3, 2024 at 6:08 AM Drew Fustini <dfustini@xxxxxxxxxxxxxxx> wrote: > From: Emil Renner Berthing <emil.renner.berthing@xxxxxxxxxxxxx> > > Add pinctrl driver for the T-Head TH1520 RISC-V SoC. > > Tested-by: Thomas Bonnefille <thomas.bonnefille@xxxxxxxxxxx> > Signed-off-by: Emil Renner Berthing <emil.renner.berthing@xxxxxxxxxxxxx> > [dfustini: check unit address to identify the pin controller instance] > Signed-off-by: Drew Fustini <dfustini@xxxxxxxxxxxxxxx> Overall the patch is in merge quality state, I just want the DT people to tell how we are to handle the groups. I personally would prefer a custom property over the unit name but let's see what they say. Yours, Linus Walleij
