On Wed, Sep 04, 2024 at 06:02:38PM +0200, Vasileios Amoiridis wrote: > Resources definition can become simpler and more organised by using the > dedicated helpers. Suggested-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> ... > + *r = DEFINE_RES_IRQ_NAMED(irq, name ? name : of_node_full_name(dev)) Just use Elvis to make this shorten. Btw, have you ever compiled this? > + r->flags |= irq_get_trigger_type(irq); -- With Best Regards, Andy Shevchenko