On Tue, 03 Sep 2024, Jani Nikula <jani.nikula@xxxxxxxxxxxxxxx> wrote: > On Tue, 03 Sep 2024, Robert Foss <rfoss@xxxxxxxxxx> wrote: >> On Mon, 12 Aug 2024 16:51:00 +0200, Marc Gonzalez wrote: >>> TDP158 is an AC-coupled DVI / HDMI to TMDS level shifting Redriver. >>> >>> Like the TFP410, the TDP158 can be set up in 2 different ways: >>> 1) hard-coding its configuration settings using pin-strapping resistors >>> 2) placing it on an I2C bus, and defer set-up until run-time >>> >>> The mode is selected by pin 8 = I2C_EN >>> I2C_EN = 1 ==> I2C Control Mode >>> I2C_EN = 0 ==> Pin Strap Mode >>> >>> [...] >> >> Applied, thanks! >> >> [1/2] dt-bindings: display: bridge: add TI TDP158 >> https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/887665792b99 >> [2/2] drm/bridge: add support for TI TDP158 >> https://gitlab.freedesktop.org/drm/misc/kernel/-/commit/a15710027afb > > Fails build with: > > ../drivers/gpu/drm/bridge/ti-tdp158.c: In function ‘tdp158_enable’: > ../drivers/gpu/drm/bridge/ti-tdp158.c:31:9: error: implicit declaration of function ‘gpiod_set_value_cansleep’ [-Werror=implicit-function-declaration] > 31 | gpiod_set_value_cansleep(tdp158->enable, 1); > | ^~~~~~~~~~~~~~~~~~~~~~~~ > ../drivers/gpu/drm/bridge/ti-tdp158.c: In function ‘tdp158_probe’: > ../drivers/gpu/drm/bridge/ti-tdp158.c:80:26: error: implicit declaration of function ‘devm_gpiod_get_optional’; did you mean ‘devm_regulator_get_optional’? [-Werror=implicit-function-declaration] > 80 | tdp158->enable = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW); > | ^~~~~~~~~~~~~~~~~~~~~~~ > | devm_regulator_get_optional > ../drivers/gpu/drm/bridge/ti-tdp158.c:80:65: error: ‘GPIOD_OUT_LOW’ undeclared (first use in this function) > 80 | tdp158->enable = devm_gpiod_get_optional(dev, "enable", GPIOD_OUT_LOW); > | ^~~~~~~~~~~~~ > ../drivers/gpu/drm/bridge/ti-tdp158.c:80:65: note: each undeclared identifier is reported only once for each function it appears in Fix at [1]. BR, Jani. [1] https://lore.kernel.org/r/20240904085206.3331553-1-jani.nikula@xxxxxxxxx -- Jani Nikula, Intel
