On Tue, Sep 03, 2024 at 11:36:28AM GMT, Bartosz Golaszewski wrote: > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > Add a node for the PMU of the WCN6855 and rework the inputs of the wifi > and bluetooth nodes to consume the PMU's outputs. > > Tested-by: Steev Klimaszewski <steev@xxxxxxxx> # Thinkpad X13s > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > --- > .../qcom/sc8280xp-lenovo-thinkpad-x13s.dts | 98 ++++++++++++++++--- > 1 file changed, 86 insertions(+), 12 deletions(-) > > diff --git a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > index 6a28cab97189..88b31550f9df 100644 > --- a/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > +++ b/arch/arm64/boot/dts/qcom/sc8280xp-lenovo-thinkpad-x13s.dts > @@ -400,6 +400,67 @@ usb1_sbu_mux: endpoint { > }; > }; > }; > + > + wcn6855-pmu { > + compatible = "qcom,wcn6855-pmu"; > + > + pinctrl-0 = <&wlan_en>; > + pinctrl-names = "default"; > + > + wlan-enable-gpios = <&tlmm 134 GPIO_ACTIVE_HIGH>; > + bt-enable-gpios = <&tlmm 133 GPIO_ACTIVE_HIGH>; > + > + vddio-supply = <&vreg_s10b>; > + vddaon-supply = <&vreg_s12b>; > + vddpmu-supply = <&vreg_s12b>; > + vddrfa0p95-supply = <&vreg_s12b>; > + vddrfa1p3-supply = <&vreg_s11b>; > + vddrfa1p9-supply = <&vreg_s1c>; > + vddpcie1p3-supply = <&vreg_s11b>; > + vddpcie1p9-supply = <&vreg_s1c>; As the WiFi is now properly using the PMU, should we also remove some of the regulator-always-on properties? > + -- With best wishes Dmitry