On Fri, Aug 16, 2024 at 11:10 AM Bartosz Golaszewski <brgl@xxxxxxxx> wrote: > > On Fri, Aug 16, 2024 at 10:26 AM Kalle Valo <kvalo@xxxxxxxxxx> wrote: > > > > Bartosz Golaszewski <brgl@xxxxxxxx> writes: > > > > > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > > > > > Describe the inputs from the PMU of the ath11k module on WCN6855. > > > > > > Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx> > > > --- > > > v1 -> v2: > > > - update the example > > > > > > .../net/wireless/qcom,ath11k-pci.yaml | 29 +++++++++++++++++++ > > > 1 file changed, 29 insertions(+) > > > > This goes to ath-next, not net-next. > > > > > diff --git a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml > > > index 8675d7d0215c..a71fdf05bc1e 100644 > > > --- a/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml > > > +++ b/Documentation/devicetree/bindings/net/wireless/qcom,ath11k-pci.yaml > > > @@ -50,6 +50,9 @@ properties: > > > vddrfa1p7-supply: > > > description: VDD_RFA_1P7 supply regulator handle > > > > > > + vddrfa1p8-supply: > > > + description: VDD_RFA_1P8 supply regulator handle > > > + > > > vddpcie0p9-supply: > > > description: VDD_PCIE_0P9 supply regulator handle > > > > > > @@ -77,6 +80,22 @@ allOf: > > > - vddrfa1p7-supply > > > - vddpcie0p9-supply > > > - vddpcie1p8-supply > > > + - if: > > > + properties: > > > + compatible: > > > + contains: > > > + const: pci17cb,1103 > > > + then: > > > + required: > > > + - vddrfacmn-supply > > > + - vddaon-supply > > > + - vddwlcx-supply > > > + - vddwlmx-supply > > > + - vddrfa0p8-supply > > > + - vddrfa1p2-supply > > > + - vddrfa1p8-supply > > > + - vddpcie0p9-supply > > > + - vddpcie1p8-supply > > > > Like we discussed before, shouldn't these supplies be optional as not > > all modules need them? > > > > The answer is still the same: the ATH11K inside a WCN6855 does - in > fact - always need them. The fact that the X13s doesn't define them is > bad representation of HW and I'm fixing it in a subsequent DTS patch. > Gentle ping. Bart
