> > + ti,mode: > > + $ref: /schemas/types.yaml#/definitions/uint8 > > + description: | > > + Operation mode > > + Mode 0 - Manual mode. A channel is only sampled when the according input > > + in the sysfs is read. > > + Mode 1 - Auto mode. All channels are automatically sampled sequentially. > > + Reading an input returns the last valid sample. In this mode further > > + features like statistics and interrupts are available. > > + default: 0 > > I don't think this ti,mode property is suitable for bindings. sysfs is a > linux implementation detail, when to do sampling is an implementation > detail of your driver. Bindings are only supposed to describe properties > of the hardware, not set software policy. Agreed. With an IIO driver this will become a switch based on what usespace interfaces are enabled. So if events are on or buffered data capture, enable automode. If just sysfs reads, then manual mode is fine. > > + > > + ads7138@10 { > > This should just be "dac@". adc :) > > > + compatible = "ti,ads7138"; > > + reg = <0x10>; > > + avdd-supply = <®_stb_3v3>; > > + ti,mode = /bits/ 8 <1>; > > + ti,interval = /bits/ 16 <1000>; > > + interrupt-parent = <&gpio2>; > > + interrupts = <12 IRQ_TYPE_LEVEL_LOW>; > > + status = "okay"; > > + }; > > + }; > oCheers, > Conor.