On Thu, 29 Aug 2024 21:19:57 +0200
Vasileios Amoiridis <vassilisamir@xxxxxxxxx> wrote:
> On Thu, Aug 29, 2024 at 03:40:34PM +0300, Andy Shevchenko wrote:
> > On Wed, Aug 28, 2024 at 10:51:26PM +0200, Vasileios Amoiridis wrote:
> > > The BMP3xx and BMP5xx sensors have an interrupt pin which can be used as
> > > a trigger for when there are data ready in the sensor for pick up.
> > >
> > > This use case is used along with NORMAL_MODE in the sensor, which allows
> > > the sensor to do consecutive measurements depending on the ODR rate value.
> > >
> > > The trigger pin can be configured to be open-drain or push-pull and either
> > > rising or falling edge.
> > >
> > > No support is added yet for interrupts for FIFO, WATERMARK and out of range
> > > values.
> >
> > > Signed-off-by: Vasileios Amoiridis <vassilisamir@xxxxxxxxx>
> > > ---
> > > drivers/iio/pressure/bmp280-core.c | 231 ++++++++++++++++++++++++++++-
> > > drivers/iio/pressure/bmp280.h | 21 +++
> > > 2 files changed, 250 insertions(+), 2 deletions(-)
> >
> > ...
> >
> > > +static int __bmp280_trigger_probe(struct iio_dev *indio_dev,
> > > + const struct iio_trigger_ops *trigger_ops,
> > > + int (*int_config)(struct bmp280_data *data),
> > > + irq_handler_t irq_thread_handler)
> > > +{
> > > + struct bmp280_data *data = iio_priv(indio_dev);
> >
> > With
> >
> > struct device *dev = data->dev;
> >
> > you may shorten some lines below and collapse a few.
> >
>
> ACK.
>
> > > + struct fwnode_handle *fwnode;
> > > + int ret, irq, irq_type;
> >
> > Why irq_type is signed?
> >
>
> True, this can be made u32.
>
> > Also try to make that returned variable is closer to the end of the definition
> > block. And it might be worth to follow reversed xmas tree order (longer lines
> > first).
> >
> > > + struct irq_data *desc;
> > > +
> > > + irq = fwnode_irq_get(dev_fwnode(data->dev), 0);
> > > + if (irq < 0)
> > > + return dev_err_probe(data->dev, irq, "No interrupt found.\n");
> > > +
> > > + desc = irq_get_irq_data(irq);
> > > + irq_type = irqd_get_trigger_type(desc);
> >
> > So, altogether it may be written as
> >
> > irq_type = irqd_get_trigger_type(irq_get_irq_data(irq));
> >
> > And looking further, we have a helper for that:
> > irq_get_trigger_type(). Why not use it?
> >
>
> I was not aware of that, I can definitely change it.
Nice. A quick grep suggests a bunch of other places
where this cleanup applies.
Maybe I'll do it this weekend, but if not patches welcome ;)
Jonathan
