Hi Conor, On Fri, Aug 30, 2024 at 11:14 AM Conor Dooley <conor@xxxxxxxxxx> wrote: > Since those don't come from spi-peripheral-props, not really the correct > justification (although why they don't, I'm not sure). If you still saw > dtbs_check complaints after the first patch, I maybe the controller > schema is missing a reference to spi-controller.yaml? I changed the first patch as suggested: --- a/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml +++ b/Documentation/devicetree/bindings/spi/spi-peripheral-props.yaml @@ -29,6 +29,10 @@ properties: description: Chip select used by the device. + spi-cpha: true + + spi-cpol: true + spi-cs-high: $ref: /schemas/types.yaml#/definitions/flag description: spi-rockchip.yaml does reference spi-controller.yaml, but I still get dtbs_check complaints after the first patch. $ make CHECK_DTBS=y rockchip/rv1108-elgin-r1.dtb -j12 UPD include/config/kernel.release SCHEMA Documentation/devicetree/bindings/processed-schema.json DTC [C] arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb /home/fabio/linux-next/arch/arm/boot/dts/rockchip/rv1108-elgin-r1.dtb: display@0: 'spi-cpha', 'spi-cpol' do not match any of the regexes: 'pinctrl-[0-9]+' from schema $id: http://devicetree.org/schemas/trivial-devices.yaml# I would appreciate some suggestions on how to fix this warning. Thanks