On Thu, Aug 29, 2024 at 05:13:15PM -0300, Fabio Estevam wrote: > There may be cases where a trivial-device needs to describe > the SPI clock polarity and phase via spi-cpol and spi-cpha > properties. Since those don't come from spi-peripheral-props, not really the correct justification (although why they don't, I'm not sure). If you still saw dtbs_check complaints after the first patch, I maybe the controller schema is missing a reference to spi-controller.yaml? That said, I think the reference is useful for other the properties, like spi-max-frequency, so the diff here is sound. Thanks, Conor. > > Add a reference to spi-peripheral-props.yaml to allow that. > > Suggested-by: Rob Herring <robh@xxxxxxxxxx> > Signed-off-by: Fabio Estevam <festevam@xxxxxxxxx> > --- > Documentation/devicetree/bindings/trivial-devices.yaml | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Documentation/devicetree/bindings/trivial-devices.yaml b/Documentation/devicetree/bindings/trivial-devices.yaml > index 75a5fad08c44..356b89ade6a8 100644 > --- a/Documentation/devicetree/bindings/trivial-devices.yaml > +++ b/Documentation/devicetree/bindings/trivial-devices.yaml > @@ -424,6 +424,9 @@ required: > - compatible > - reg > > -additionalProperties: false > +allOf: > + - $ref: /schemas/spi/spi-peripheral-props.yaml# > + > +unevaluatedProperties: false > > ... > -- > 2.34.1 >
Attachment:
signature.asc
Description: PGP signature
