On 29/08/2024 11:03, Nick Chan wrote: > Document the compatibles for Apple A7-A11 SoCs. > > There are three feature levels: > - A7-A10: No fast IPI > - A11: fast IPI, global only > - M1: fast IPI with local and global support > > Each feature level is an extension of the previous. For example, M1 will > also work with the A7 feature level. It's hard for me to map above to compatibles. Extend the commit msg to include names used in the bindings. > > Signed-off-by: Nick Chan <towinchenmi@xxxxxxxxx> > --- > .../bindings/interrupt-controller/apple,aic.yaml | 15 ++++++++++++--- > 1 file changed, 12 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml > index 698588e9aa86..28e09b933087 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/apple,aic.yaml > @@ -36,9 +36,18 @@ allOf: > > properties: > compatible: > - items: > - - const: apple,t8103-aic > - - const: apple,aic > + oneOf: > + - const: apple,s5l8960x-aic Which one is this? > + - items: > + - enum: > + - apple,s8000-aic > + - apple,t7000-aic > + - apple,t8010-aic > + - const: apple,s5l8960x-aic > + - items: > + - const: apple,t8103-aic > + - const: apple,t8015-aic Why are you changing all existing devices? Test your change, you would see here errors. Best regards, Krzysztof