On 29/08/2024 13:09, Nick Chan wrote: > > > On 29/8/2024 18:24, Rob Herring (Arm) wrote: >> >> On Thu, 29 Aug 2024 17:03:11 +0800, Nick Chan wrote: >>> Document the compatibles for Apple A7-A11 SoCs. >>> >>> There are three feature levels: >>> - A7-A10: No fast IPI >>> - A11: fast IPI, global only >>> - M1: fast IPI with local and global support >>> >>> Each feature level is an extension of the previous. For example, M1 will >>> also work with the A7 feature level. >>> >>> Signed-off-by: Nick Chan <towinchenmi@xxxxxxxxx> >>> --- >>> .../bindings/interrupt-controller/apple,aic.yaml | 15 ++++++++++++--- >>> 1 file changed, 12 insertions(+), 3 deletions(-) >>> >> >> My bot found errors running 'make dt_binding_check' on your patch: >> >> yamllint warnings/errors: >> >> dtschema/dtc warnings/errors: >> /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/interrupt-controller/apple,aic.example.dtb: interrupt-controller@23b100000: compatible: 'oneOf' conditional failed, one must be fixed: >> ['apple,t8103-aic', 'apple,aic'] is too long >> ['apple,t8103-aic', 'apple,aic'] is too short >> 'apple,s5l8960x-aic' was expected >> 'apple,t8103-aic' is not one of ['apple,s8000-aic', 'apple,t7000-aic', 'apple,t8010-aic'] >> 'apple,t8015-aic' was expected >> from schema $id: http://devicetree.org/schemas/interrupt-controller/apple,aic.yaml# >> >> doc reference errors (make refcheckdocs): >> >> See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20240829092610.89731-2-towinchenmi@xxxxxxxxx >> >> The base for the series is generally the latest rc1. A different dependency >> should be noted in *this* patch. >> >> If you already ran 'make dt_binding_check' and didn't see the above >> error(s), then make sure 'yamllint' is installed and dt-schema is up to >> date: > Acked. yamllint was not installed on my system. > The error are not coming from yamllint. It's not about yamllint. You just never tested the binding. Best regards, Krzysztof